Re: [PATCH 15/15] tracing/kprobes: Fix kprobe-tracer to supportstack trace

[Ingo Molnar]

* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> > > +	__ftrace_trace_stack(global_trace.buffer, flags, 3, preempt_count(),
> > > +			     NULL);
> > 
> > pointless linebreak.
> 
> Again, probably to do with the 80 char limit.

Well, the point of the 80 char limit warning these days is to force a 
cleanup of the code. Breaking the line mindlessly *uglifies* the code 
so it's pointless to do it.

In terms of terminal readability line length up to 90-100 cols is 
acceptable for code that is otherwise not ugly.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/