Re: [PATCH] ieee802154: Don't leak memory in ieee802154_nl_fill_phy

From: Dmitry Eremin-Solenikov
Date: Mon Jun 13 2011 - 16:02:43 EST


On 6/12/11, Jesper Juhl <jj@xxxxxxxxxxxxx> wrote:
> In net/ieee802154/nl-phy.c::ieee802154_nl_fill_phy() I see two small
> issues.
> 1) If the allocation of 'buf' fails we may just as well return -EMSGSIZE
> directly rather than jumping to 'out:' and do a pointless kfree(0).
> 2) We do not free 'buf' unless we jump to one of the error labels and this
> leaks memory.
> This patch should address both.
>
> Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>

Acked-by: Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx>

David, please commit this.

--
With best wishes
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/