Re: [PATCH 1/3] usbip: only dump valid port status

[Joe Perches]

On Mon, 2011-06-13 at 23:29 +0200, NÃmeth MÃrton wrote:
> From: MÃrton NÃmeth <nm127@xxxxxxxxxxx>
> 
> The wIndex parameter of vhci_hub_control() is always zero when the
> request type is GetHubDescriptor,
> ---
> diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c
> @@ -464,8 +464,11 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
> 
>  	if (usbip_dbg_flag_vhci_rh) {
>  		pr_debug("port %d\n", rhport);
> -		dump_port_status(prev_port_status[rhport]);
> -		dump_port_status(dum->port_status[rhport]);
> +		/* Only dump valid port status */
> +		if (0 <= rhport) {
> +			dump_port_status(prev_port_status[rhport]);
> +			dump_port_status(dum->port_status[rhport]);
> +		}
>  	}
>  	usbip_dbg_vhci_rh(" bye\n");
> 

Linux relatively rarely uses constant before variable in a comparison.
ie: please use "if (rhport > 0)" instead


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/