Re: [PATCH] writeback: trace global_dirty_state

[Wu Fengguang]

On Mon, Jun 13, 2011 at 10:33:56PM +0800, Jan Kara wrote:
> On Fri 10-06-11 22:48:05, Wu Fengguang wrote:
> > [It seems beneficial to queue this simple trace event for
> >  next/upstream after the review?]
> > 
> > Add trace event balance_dirty_state for showing the global dirty page
> > counts and thresholds at each global_dirty_limits() invocation.  This
> > will cover the callers throttle_vm_writeout(), over_bground_thresh()
> > and each balance_dirty_pages() loop.
>   OK, this might be useful. But shouldn't we also add similar trace point
> for bdi limits? Otherwise the information is of limited use...

Good point. The bdi limits will be exported in another
balance_dirty_pages trace point.

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/