[PATCH] s3c2410_udc: udc command always disables pull-up instead ofpassing the command

[Skacore Systems]

Hello *,

Sorry for the HTML,
There is a bug in s3c2410_udc driver, which triggers when using custom
UDC command for USB pull-up.
As a result driver is always calling user defined UDC command with
wrong parameter (S3C2410_UDC_P_DISABLE) instead of
just passing the parameter to the user defined function.

BR.

Vilo

--- Linux-2.6.39-wp/2.6.39/drivers/usb/gadget/s3c2410_udc.c
2011-05-19 06:06:34.000000000 +0200
+++ Linux-2.6.39/linux-paytec/drivers/usb/gadget/s3c2410_udc.c
2011-06-14 11:59:55.000000000 +0200
@@ -1566,7 +1566,7 @@
                return;
        if (udc_info->udc_command) {
-               udc_info->udc_command(S3C2410_UDC_P_DISABLE);
+               udc_info->udc_command(cmd);
        } else if (gpio_is_valid(udc_info->pullup_pin)) {
                int value;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/