Re: [ath9k-devel] [PATCH net-next 1/2] wireless: Remove casts ofvoid *

From: Pavel Roskin
Date: Tue Jun 14 2011 - 12:41:32 EST


On 06/14/2011 12:02 AM, Joe Perches wrote:

/* Get the message ID */
- msg_id = (__be16 *) ((void *) htc_hdr +
- sizeof(struct htc_frame_hdr));
+ msg_id = (void *)htc_hdr + sizeof(struct htc_frame_hdr);

I would never do stuff like this without verifying by sparse that no warnings are introduced.

Sparse warnings should be avoided to keep sparse checks useful. Otherwise, important warnings would drown in the noise.

--
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/