Re: [PATCH] fix bogus use of rc = alloc_chrdev_region()

From: Arnd Bergmann
Date: Tue Jun 14 2011 - 14:18:08 EST


On Tuesday 14 June 2011 18:23:50 Grant Likely wrote:
> On Tue, Jun 14, 2011 at 8:07 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> > On the topic of drivers/char/{nsc_gpio,pc8736x_gpio,scx200_gpio}, I wonder
> > if we should move them to drivers/gpio/nsc_gpio despite the fact that they
> > use a different (older) interface than all the other gpio drivers.
>
> I have no problem with moving them into drivers/gpio. When you do,
> please rename then drivers/gpio/gpio-*.c

Ok. Should they be in a subdirectory drivers/gpio/nsc_gpio/gpio_* for the
nonstandard API or do you prefer them to live amongst the regular ones?

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/