Re: [PATCH] x86, vsyscall: Fix build warning in vsyscall_64.c

From: Ingo Molnar
Date: Tue Jun 14 2011 - 17:31:25 EST



* Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Tue, Jun 14, 2011 at 2:16 PM, Ingo Molnar <mingo@xxxxxxx> wrote:
> >
> > I think correctness trumps code size and turning BUG() and BUG_ON()
> > into a NOP is just crazy ...
>
> Umm. It's even CRAZIER to turn it into a "compiler generates random code".

Sigh, i assumed it got turned into an infinite loop - that is what
i've done in a prior patch.

You are right, unreachable() is bogus and you'd also be right to
suggest that i should not comment on patches after 11pm ;-)

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/