Re: [PATCH 3.0-rc3, v2] i915: Fix gen6 (SNB) GPU stalling

[Daniel J Blueman]

On 18 June 2011 01:44, Eric Anholt <eric@xxxxxxxxxx> wrote:
> On Sat, 18 Jun 2011 00:42:00 +0800, Daniel J Blueman <daniel.blueman@xxxxxxxxx> wrote:
>> Workaround Sandy Bridge GPU stalls by allowing the blitter command streamer
>> to write interrupt state to the Hardware Status Page when a MI_USER_INTERRUPT
>> command is decoded.
>>
>> v1->v2: Moved to prior interrupt handler installation and RMW flags as per
>> feedback.
>
> We shouldn't be RMWing.  We're the driver, we're supposed to know what
> we want.  I'm backing that bit out, will do another round of testing,
> and send it off.

I still prefer directly setting the mask due to my earlier reasons.
Unmasking in the IRQ preinstall tests good here, so I'll send a v3
patch in the morning.

Thanks,
  Daniel
-- 
Daniel J Blueman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/