Re: [PATCH 1/10 v2] Generic Watchdog Timer Driver

[Randy Dunlap]

On Sat, 18 Jun 2011 20:58:14 +0200 Arnd Bergmann wrote:

> On Saturday 18 June 2011 19:19:46 Wim Van Sebroeck wrote:
> > watchdog: WatchDog Timer Driver Core - Part 1
> > 
> > The WatchDog Timer Driver Core is a framework
> > that contains the common code for all watchdog-driver's.
> > It also introduces a watchdog device structure and the
> > operations that go with it.
> > 
> > This is the introduction of this framework. This part
> > supports the minimal watchdog userspace API (or with
> > other words: the functionality to use /dev/watchdog's
> > open, release and write functionality as defined in
> > the simplest watchdog API). Extra functionality will
> > follow in the next set of patches.
> > 
> > Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Wim Van Sebroeck <wim@xxxxxxxxx>
> 
> Hi Wim,
> 
> Great to see the series posted again, I'm looking forward to seeing
> this included in 3.1.
> 
> I've got a few comments for stuff that can still be improved.
> 
> I noticed that your email subject lines are all the same, you should
> probably see if you mail setup can be fixed to take the one-line
> comment in each patch as the subject, and also to make all mails
> replies to the [PATCH 0/10] email.

It would also be good to include diffstat summaries with each patch.

This info in Documentation/ioctl/ioctl-number.txt does not change, correct?

'W'	00-1F	linux/watchdog.h	conflict!

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/