Re: [PATCH 1/3] mm: completely disable THP by transparent_hugepage=never

From: Cong Wang
Date: Mon Jun 20 2011 - 23:29:04 EST


ä 2011å06æ21æ 01:50, Rik van Riel åé:
On 06/20/2011 01:34 PM, Cong Wang wrote:

Even if it is really 10K, why not save it since it doesn't
much effort to make this. ;) Not only memory, but also time,
this could also save a little time to initialize the kernel.

For me, the more serious thing is the logic, there is
no way to totally disable it as long as I have THP in .config
currently. This is why I said the design is broken.

There are many things you cannot totally disable as long
as they are enabled in the .config. Think about things
like swap, or tmpfs - neither of which you are going to
use in the crashdump kernel.

Sure, things like CONFIG_KEXEC can never be disabled
without changing .config too, they are designed like this.

Some features _do_ only mean to be disabled only
by Kconfig, some syscalls are indeed good examples here,
but some features don't. THP is one of them, because features
like this can be tuned dynamically.


I believe we need to keep the kernel optimized for common
use and convenience.

Crashdump is very much a corner case. Yes, using less
memory in crashdump is worthwhile, but lets face it -
the big memory user there is likely to be the struct page
array, with everything else down in the noise...

For the 128M case, only the struct page's of the 128M is
constructed in the second kernel, which unlikely to be a big user.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/