Re: [PATCH] svcsock.c: include sunrpc.h to quite sparse noise

From: J. Bruce Fields
Date: Tue Jun 21 2011 - 18:44:24 EST


On Mon, Jun 20, 2011 at 05:54:51PM -0700, H Hartley Sweeten wrote:
> Include the private header sunrpc.h to pickup the declaration of the
> function svc_send_common to quiet the following sparse noise:
>
> warning: symbol 'svc_send_common' was not declared. Should it be static?

Thanks, applying for 3.1--b.

>
> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
> Cc: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
> Cc: "J. Bruce Fields" <bfields@xxxxxxxxxxxx>
> Cc: Neil Brown <neilb@xxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
>
> ---
>
> diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
> index af04f77..f2cb5b8 100644
> --- a/net/sunrpc/svcsock.c
> +++ b/net/sunrpc/svcsock.c
> @@ -51,6 +51,8 @@
> #include <linux/sunrpc/stats.h>
> #include <linux/sunrpc/xprt.h>
>
> +#include "sunrpc.h"
> +
> #define RPCDBG_FACILITY RPCDBG_SVCXPRT
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/