Re: [PATCH] PCI / PM: Block races between runtime PM and systemsleep
From: Alan Stern
Date: Wed Jun 22 2011 - 10:20:35 EST
On Wed, 22 Jun 2011, Rafael J. Wysocki wrote:
> > It's probably okay to prevent pm_runtime_suspend() from working during
> > .suspend() or .resume(), but it's not a good idea to prevent
> > pm_runtime_resume() from working then.
> OK, but taking a reference by means of pm_runtime_get_noresume() won't
> block pm_runtime_resume().
Exactly my point -- we don't need to (and don't want to) block
pm_runtime_resume during the .suspend() and .resume() callbacks.
> > During the .suspend and .resume callbacks, races with
> > .runtime_suspend() can be prevented by calling
> > pm_runtime_get_noresume() just before .suspend() and then calling
> > pm_runtime_put_sync() just after .resume().
> So, you seem to suggest to call pm_runtime_get_noresume() in
> __device_suspend() and pm_runtime_put_sync() in device_resume().
Yes. Also perhaps call pm_runtime_barrier() immediately after
> That would be fine by me, perhaps up to the "sync" part of the "put".
The main feature of this design is that it allows runtime PM to work
between .resume() and .complete(). If you do a put_noidle instead of
put_sync then you may prevent runtime PM from working properly.
> > > (a _put_sync() at this point will likely invoke
> > > .runtime_idle() from the subsystem before executing .complete(), which may
> > > not be desirable)?
> > It should be allowed. The purpose of .complete() is not to re-enable
> > runtime power management of the device; it is to release resources
> > (like memory) allocated during .prepare() and perhaps also to allow new
> > children to be registered under the device.
> Right. But does "allowed" mean the core _should_ do it at this point?
> We may as well call pm_runtime_idle() directly from rpm_complete(), but
> perhaps it's better to call it from device_resume(), so that it runs in
> parallel for async devices.
Calling pm_runtime_put_noidle() followed by pm_runtime_idle() is
essentially the same as calling pm_runtime_put_sync() anyway.
If a subsystem really does want to block runtime PM between the
.resume() and .complete() callbacks, it can do its own get_noresume and
put_sync -- just as you have done with PCI.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/