Re: [PATCH 14/19] OpenRISC: Module support

From: Jonas Bonn
Date: Wed Jun 22 2011 - 15:14:18 EST


On Wed, 2011-06-22 at 16:26 +0200, Arnd Bergmann wrote:
> On Tuesday 21 June 2011, Valdis.Kletnieks@xxxxxx wrote:
> > On Sun, 19 Jun 2011 13:43:40 +0200, Jonas Bonn said:
>
> > > diff --git a/arch/openrisc/kernel/module.c b/arch/openrisc/kernel/module.c
> > > new file mode 100644
> > > index 0000000..952b129
> > > --- /dev/null
> > > +++ b/arch/openrisc/kernel/module.c
> > > @@ -0,0 +1,126 @@
> > > +/*
> > > + * OpenRISC module.c
> >
> > Lose the filenames in the headers - you do this in multiple files.
>
> Good point.

What's an acceptable "comment title"? Most other arch's seem to put the
filename there... I understand this is undesirable, but what can I put
there instead? Is "OpenRISC Linux" acceptable, or is nothing at all
preferable?

Just want to be clear about what's allowed before I go changing all of
these...

/Jonas

Attachment: signature.asc
Description: This is a digitally signed message part