Re: [RFC] sched: update rto_mask for RT runqueue

From: Steven Rostedt
Date: Thu Jun 23 2011 - 13:55:38 EST


On Thu, 2011-06-23 at 21:43 +0800, Hillf Danton wrote:
> Hi Steven
>
> Since {de, en}queue_pushable_task() is not always accompanied with
> {dec, inc}_rt_migration(), when the last pushable RT task on RQ is picked in
> pick_next_task_rt(), we have to update rto_mask for the RQ in question, which
> helps puller that is guided by rto_mask.

Hmm, I don't care much for this patch, but you did bring up something
that is interesting. That there may be a disconnect between the rto_mask
and the pushable tasks. A pushable task is the same as a pullable task.
So I'm thinking about revamping this to merge the two and make the code
simpler.

This may take a lot of testing to make sure that we did not create any
regressions.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/