Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure

From: Ralf Baechle
Date: Fri Jun 24 2011 - 09:08:35 EST


On Fri, Jun 24, 2011 at 02:22:41PM +0200, Takashi Iwai wrote:

> > o The drivers/media/radio/Kconfig part should be applied for 3.0 and
> > maybe -stable.
>
> Yes, this will be good.

I just tested that segment only and it works as expected. Will repost in
a minute.

> > o The sound/isa/Kconfig part is basically only fixing the dependency for
> > the Adlib driver allowing it to be built on non-ISA_DMA_API system and
> > is material for the next release after 3.0.
>
> Any serious reason that snd-adlib must be built even with ISA=n?

Definately not.

> As the device is really present only for ISA, it doesn't make much
> sense to build this even though the driver itself doesn't need
> ISA_DMA_API.

I'm not aware of any systems that could use the Adlib in a ISA=n
environment. That's why my patch left the dependency on ISA untouched.

Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/