Re: {PATCH] fix __packed in exported kernel headers

[Michal Marek]

On 24.6.2011 15:51, Markus Trippelsdorf wrote:
> checkpatch.pl warns about using __attribute__((packed)) in kernel
> headers: "__packed is preferred over __attribute__((packed))". If one
> follows that advice it could cause problems in the exported header
> files, because the outside world doesn't know about this shortcut.
>
> For example busybox will fail to compile:
>   CC      miscutils/ubi_attach_detach.o
>   In file included from miscutils/ubi_attach_detach.c:27:0:
>   /usr/include/mtd/ubi-user.h:330:3: error: conflicting types for â__packedâ
>   /usr/include/mtd/ubi-user.h:314:3: note: previous declaration of â__packedâ was here
> ...
>
> Fix the problem by substituting __packed with __attribute__((packed)) in
> the header_install.pl script.
>
> Cc: Artem Bityutskiy<Artem.Bityutskiy@xxxxxxxxx>
> CC: Joe Perches<joe@xxxxxxxxxxx>
> Signed-off-by: Markus Trippelsdorf<markus@xxxxxxxxxxxxxxx>
> ---
>   scripts/headers_install.pl |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)

Thanks, applied to kbuild-2.6.git#kbuild.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/