Re: {PATCH] fix __packed in exported kernel headers

[Mike Frysinger]

On Fri, Jun 24, 2011 at 12:33, Arnd Bergmann wrote:
> On Friday 24 June 2011, Markus Trippelsdorf wrote:
>> checkpatch.pl warns about using __attribute__((packed)) in kernel
>> headers: "__packed is preferred over __attribute__((packed))". If one
>> follows that advice it could cause problems in the exported header
>> files, because the outside world doesn't know about this shortcut.
>>
>> For example busybox will fail to compile:
>> ÂCC Â Â Âmiscutils/ubi_attach_detach.o
>> ÂIn file included from miscutils/ubi_attach_detach.c:27:0:
>> Â/usr/include/mtd/ubi-user.h:330:3: error: conflicting types for â__packedâ
>> Â/usr/include/mtd/ubi-user.h:314:3: note: previous declaration of â__packedâ was here
>> ...
>>
>> Fix the problem by substituting __packed with __attribute__((packed)) in
>> the header_install.pl script.
>
> No objections to the patch, but it should probably be noted that user
> visible data structures should ideally not have any attributes, because
> that requires building all applictions using that interface with gcc.
>
> We generally try to add no such requirements on user applications.

the only real solution there is to export the compiler.h headers too

plus, many compilers nowadays (like icc/llvm) tend to include support
for common gcc attributes ...
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/