RE: [PATCH v3] Add support for the Philips SA56004 temperature sensor.

From: Stijn Devriendt (sdevrien)
Date: Mon Jun 27 2011 - 03:09:28 EST


> On Mon, Jun 6, 2011 at 12:40 PM, <sdevrien@xxxxxxxxx> wrote:
> > +       } else
> > +       if (man_id == 0xA1) { /*  NXP Semiconductor/Philips */
>
> No kernel coder writes like this. Has this ever been run through
> checkpatch ?
It has. Unfortunately this is just the coding style in the whole
driver. I believe it's better to have a consistent file rather
than 3 different styles.

Stijn

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/