Re: [PATCH -next] bcma: main.c needs to include <linux/slab.h>

[Arend van Spriel]

On 06/27/2011 04:43 PM, RafaÅ MiÅecki wrote:
> W dniu 27 czerwca 2011 16:24 uÅytkownik Alexey Dobriyan
> <adobriyan@xxxxxxxxx>  napisaÅ:
> > 2011/6/27 RafaÅ MiÅecki<zajec5@xxxxxxxxx>:
> > > 2011/6/26 Geert Uytterhoeven<geert@xxxxxxxxxxxxxx>:
> > > > m68k allmodconfig:
> > > >
> > > > drivers/bcma/main.c: In function âbcma_release_core_devâ:
> > > > drivers/bcma/main.c:68: error: implicit declaration of function âkfreeâ
> > > We already include slab.h in:
> > > host_pci.c
> > > scan.c
> > > sprom.c
> > >
> > > Maybe we can just include this in bcma.h as a better solution?
> > It isn't better solution.
> > It results in situation where unnecessary inclusion will be done.
> > Maybe it's not the case now, but it will be in future.
> Scanning code is required for every BCMA board, so we already include
> linux/slab.h on every configuration. No matter if this is PCI host
> board, or SoC, or whatever we will support in the future.
> Now we discovered this is also needed in main.c, which will be always compiled.
>
> That's why I think it's safe to include linux/slab.h in bcma_private.h.
> But if that's just my opinion, everybody think it's wrong idea, I'm OK with it.

My rule of thumb is: Header file a.h may only include header b.h when 
a.h needs some definition from b.h. Convenience is never a good reason 
for nested includes.

Gr. AvS

--
Almost nobody dances sober, unless they happen to be insane.
-- H.P. Lovecraft --


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/