Re: [PATCH 7/7] serial/8250: make PIO support optional

From: Alan Cox
Date: Tue Jun 28 2011 - 06:06:34 EST


> This makes the PIO support in the 8250 driver completely
> conditional on CONFIG_HAS_IOPORT so we can remove the bogus
> definitions from all the places that only need them for 8250.

NAK this as last time.

We had a discussion about how to fix this properly. I even posted some
sketched out patches to show how it could be addressed

Shotgunning the code with ifdefs was not that.


Get the port methods out of the core code as was proposed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/