Re: [PATCH 08/11] dynamic_debug: return int from ddebug_change

From: Bart Van Assche
Date: Tue Jun 28 2011 - 06:30:12 EST


On Tue, Jun 28, 2011 at 9:09 AM, Jim Cromie <jim.cromie@xxxxxxxxx> wrote:
> @@ -425,6 +424,7 @@ static int ddebug_exec_query(char *query_string)
>  #define MAXWORDS 9
>        int nwords;
>        char *words[MAXWORDS];
> +       int nfound;
>
>        nwords = ddebug_tokenize(query_string, words, MAXWORDS);
>        if (nwords <= 0)
> @@ -435,7 +435,8 @@ static int ddebug_exec_query(char *query_string)
>                return -EINVAL;
>
>        /* actually go and implement the change */
> -       ddebug_change(&query, flags, mask);
> +       nfound = ddebug_change(&query, flags, mask);
> +
>        return 0;

Do these changes actually do anything, or did I miss something ?

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/