[PATCH] writeback: Don't wait for completion in writeback_inodes_sb_nr

From: Curt Wohlgemuth
Date: Tue Jun 28 2011 - 19:43:58 EST


Contrary to the comment block atop writeback_inodes_sb_nr(),
we *were* calling

wait_for_completion(&done);

which should not be done, as this is not called for data
integrity sync.

Signed-off-by: Curt Wohlgemuth <curtw@xxxxxxxxxx>
---
fs/fs-writeback.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index 0f015a0..3f711ac 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -1186,17 +1186,14 @@ static void wait_sb_inodes(struct super_block *sb)
*/
void writeback_inodes_sb_nr(struct super_block *sb, unsigned long nr)
{
- DECLARE_COMPLETION_ONSTACK(done);
struct wb_writeback_work work = {
.sb = sb,
.sync_mode = WB_SYNC_NONE,
- .done = &done,
.nr_pages = nr,
};

WARN_ON(!rwsem_is_locked(&sb->s_umount));
bdi_queue_work(sb->s_bdi, &work);
- wait_for_completion(&done);
}
EXPORT_SYMBOL(writeback_inodes_sb_nr);

--
1.7.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/