Re: [PATCH] fs: push i_mutex and filemap_write_and_wait down into->fsync() handlers

From: richard -rw- weinberger
Date: Wed Jun 29 2011 - 13:05:52 EST


On Tue, Jun 28, 2011 at 5:35 PM, Josef Bacik <josef@xxxxxxxxxx> wrote:
> Btrfs needs to be able to control how filemap_write_and_wait_range() is called
> in fsync to make it less of a painful operation, so push down taking i_mutex and
> the calling of filemap_write_and_wait() down into the ->fsync() handlers.  Some
> file systems can drop taking the i_mutex altogether it seems, like ext3 and
> ocfs2.  For correctness sake I just pushed everything down in all cases to make
> sure that we keep the current behavior the same for everybody, and then each
> individual fs maintainer can make up their mind about what to do from there.
> Thanks,
>
> Signed-off-by: Josef Bacik <josef@xxxxxxxxxx>

A small note from checkpatch.pl:

ERROR: "foo * bar" should be "foo *bar"
#1109: FILE: fs/hostfs/hostfs_kern.c:367:
+ struct inode * inode = file->f_mapping->host;

--
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/