RE: [PATCH 4/6 v3] [media] ov9740: Remove hardcoded resolution regs

From: Andrew Chew
Date: Wed Jun 29 2011 - 15:36:31 EST


> > + ret = ov9740_reg_write(client, OV9740_ISP_CTRL1E,
> scale_input_x >> 8);
> > + if (ret)
> > + goto done;
> > + ret = ov9740_reg_write(client, OV9740_ISP_CTRL1F,
> scale_input_x & 0xff);
> > + if (ret)
> > + goto done;
> > + ret = ov9740_reg_write(client, OV9740_ISP_CTRL20,
> scale_input_y >> 8);
> > + if (ret)
> > + goto done;
> > + ret = ov9740_reg_write(client, OV9740_ISP_CTRL21,
> scale_input_y & 0xff);
> > + if (ret)
> > + goto done;
>
> Now that we know what control registers 1e to 21 are for,
> what about renaming
> them ? Are they called CTRL1E to CTRL21 in the vendor documentation ?

Yes, that's what they're called in the vendor documentation, so I'd rather not make something up.--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/