Re: [PATCH v3 7/9] KVM-GST: KVM Steal time accounting

From: Glauber Costa
Date: Thu Jun 30 2011 - 22:51:14 EST


On 06/30/2011 06:54 PM, Peter Zijlstra wrote:
On Wed, 2011-06-29 at 11:29 -0400, Glauber Costa wrote:
This patch accounts steal time time in kernel/sched.
I kept it from last proposal, because I still see advantages
in it: Doing it here will give us easier access from scheduler
variables such as the cpu rq. The next patch shows an example of
usage for it.

Since functions like account_idle_time() can be called from
multiple places, not only account_process_tick(), steal time
grabbing is repeated in each account function separatedely.


That changelog is so going to frustrate someone trying to re-create your
thinking in a year's time. They really don't care about the last
proposals and the next patch.

You're right. I'll review all changelogs and rewrite them as needed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/