[rfc] Remove member .name from struct netpoll
From: Joe Perches
Date: Fri Jul 01 2011 - 13:07:58 EST
struct netpoll has member .name
struct netpoll {
struct net_device *dev;
char dev_name[IFNAMSIZ];
const char *name;
[...]
};
that is set only by netconsole.c
static struct netconsole_target *alloc_param_target(char *target_config)
{
[...]
nt->np.name = "netconsole";
and used only by net/core/netpoll.c to emit "netconsole: " on
logging messages.
e.g.
void netpoll_print_options(struct netpoll *np)
{
printk(KERN_INFO "%s: local port %d\n",
np->name, np->local_port);
I think it'd be more common to use pr_fmt and pr_<level>
to emit these logging messages.
Are there out of tree users or plans to use "struct netpoll"
by other modules?
If not, I propose to remove name from the struct.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/