Re: [PATCH v2 2/2] gpio: Add a driver for Sodaville GPIO controller
From: Sebastian Andrzej Siewior
Date: Mon Jul 04 2011 - 12:29:29 EST
Grant Likely wrote:
I tried to apply this, but it failed to build:
/home/grant/hacking/linux-2.6/drivers/gpio/gpio-sodaville.c: In
function âsdv_xlateâ:
/home/grant/hacking/linux-2.6/drivers/gpio/gpio-sodaville.c:106:15:
error: âstruct irq_domainâ has no member named âof_nodeâ
I assume there is a missing #include, you can either send a fixup
patch or a new version, your choice.
I guess you have to ask the DT maintainer which merged the irq_domain
thingy to create a topic branch for you :)
Also...
diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
index 0fbdd75..cc6d662 100644
--- a/drivers/gpio/Makefile
+++ b/drivers/gpio/Makefile
@@ -41,6 +41,7 @@ obj-$(CONFIG_GPIO_S5PV210) += gpio-s5pv210.o
obj-$(CONFIG_GPIO_SCH) += gpio-sch.o
obj-$(CONFIG_GPIO_STMPE) += gpio-stmpe.o
+obj-$(CONFIG_GPIO_SODAVILLE) += gpio-sodaville.o
obj-$(CONFIG_GPIO_SX150X) += gpio-sx150x.o
obj-$(CONFIG_GPIO_TC3589X) += gpio-tc3589x.o
obj-$(CONFIG_ARCH_TEGRA) += gpio-tegra.o
Last I checked, SO comes before ST in alphabetized lists. :-)
Ah, we use the standardized one. Is it okay to send an incremental patch
for that once it compiles?
g.
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/