Re: [PATCH] x86/EFI: properly pre-initialize table pointers

[Ingo Molnar]

* Jan Beulich <JBeulich@xxxxxxxxxx> wrote:

> Consumers of the table pointers in struct efi check for
> EFI_INVALID_TABLE_ADDR to determine validity, hence these pointers
> should all be pre-initialized to this value (rather than zero).
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
> 
> ---
>  arch/x86/platform/efi/efi.c |   12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)

This changelog is missing some key information:

 - how did you find the bug (by chance via code review or did you see
   some actual badness?)

 - what practical effect (if any) did you see from this patch?

 - what practical effect (if any) do you expect others to see from this patch?

This kind of information helps us prioritize bugfixes.

Thanks,

    Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/