Re: [PATCH 2/4] perf, x86: Add Intel Nhm/Wsm/Snb load latencysupport

[Lin Ming]

On Tue, 2011-07-05 at 21:17 +0800, Peter Zijlstra wrote:
> On Mon, 2011-07-04 at 08:02 +0000, Lin Ming wrote:
> > +#define INTEL_EVENT_EXTRA_REG2(event, msr, vm)    \
> > +       EVENT_EXTRA_REG(event, msr, ARCH_PERFMON_EVENTSEL_EVENT | \
> > +                       ARCH_PERFMON_EVENTSEL_UMASK, vm) 
> 
> That's inconsistent wrt the normal constraints, INTEL_UEVENT_EXTRA_REG
> would be the consistent name.
> 
> #define INTEL_UEVENT_EXTRA_REG(event, msr, vm)	\
> 	EVENT_EXTRA_REG(event, msr, INTEL_ARCH_EVENT_MASK, vm)

Right, thanks.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/