Re: [PATCH 02/11] GPIO: DA9052 GPIO module v2

[Arnd Bergmann]

On Tuesday 05 July 2011, ashishj3 wrote:
> DA9052 PMIC has 16 bit GPIO bus for peripheral control.
> 
> This patch add support for the GPIO pins on the DA9052.
> 
> Signed-off-by: David Dajun Chen <dchen@xxxxxxxxxxx>
> Signed-off-by: Ashish Jangam <ashish.jangam@xxxxxxxxxxxxxxx>
> CC: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
> Changes since v2
> - change of file name
> - correct reference to irq_base in function to_irq()
> - remove pdata dependency
> ---
>  drivers/gpio/Kconfig            |    6 +
>  drivers/gpio/Makefile           |    1 +
>  drivers/gpio/gpio-da9052.c      |  259 +++++++++++++++++++++++++++++++++++++++
>  include/linux/mfd/da9052/gpio.h |   47 +++++++
>  4 files changed, 313 insertions(+), 0 deletions(-)

I think I commented on this before, but please remove any header files
in include/linux that are not used as an interface between different
modules. If a header just describes properties of the hardware and is
used by a single source file, move the contents into that source file.

If a header is used by multiple files in one directory, make it a local
header in that directory.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/