Re: [PATCH 34/40] Staging: hv: storvsc: Add the contents ofhyperv_storage.h to storvsc_drv.c

[Greg KH]

On Fri, Jul 01, 2011 at 12:48:44PM +0000, KY Srinivasan wrote:
> 
> 
> > -----Original Message-----
> > From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx]
> > Sent: Friday, July 01, 2011 4:16 AM
> > To: KY Srinivasan
> > Cc: Christoph Hellwig; gregkh@xxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > devel@xxxxxxxxxxxxxxxxxxxxxx; virtualization@xxxxxxxxxxxxxx; Haiyang Zhang;
> > Abhishek Kane (Mindtree Consulting PVT LTD); Hank Janssen
> > Subject: Re: [PATCH 34/40] Staging: hv: storvsc: Add the contents of
> > hyperv_storage.h to storvsc_drv.c
> > 
> > On Thu, Jun 30, 2011 at 08:13:51PM +0000, KY Srinivasan wrote:
> > > > > Add the contents of hyperv_storage.h to storvsc_drv.c and cleanup
> > > > storvsc_drv.c.n
> > > >
> > > > I'd at least leave the first half of the header that defines the
> > > > protocol around.
> > >
> > > I only got rid of the block comment at the start of hyperv_storage.h
> > > and consolidated the include files. Nothing of substance was deleted.
> > 
> > I meant to say keeping a separate header file for the protocol defintion
> > might be a good idea.  That way it is kept separate from the
> > implementation details
> > 
> Ok; I get it. Although, a while ago as I was cleaning up the header files
> In preparation to exiting staging, Greg had indicated that each driver
> should, if possible be a single file. I merged the relevant files to comply
> with that directive. 

Well, do what makes sense.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/