ext4: why init the unused block group at batched discard?

[Kyungmin Park]

Hi Lukas,

During code review batched discard support at ext4. I wonder why do
you init the uninitialized block group during batched discard.
As you know uninitialized block group mean that there's no operation
at these blocks.
So no need to trim it at all.

How do you think?

int ext4_trim_fs(struct super_block *sb, struct fstrim_range *range)
{
        ...

        for (group = first_group; group <= last_group; group++) {
                grp = ext4_get_group_info(sb, group);
                /* We only do this if the grp has never been initialized */
                if (unlikely(EXT4_MB_GRP_NEED_INIT(grp))) {
                        ret = ext4_mb_init_group(sb, group);
                        if (ret)
                                break;
                }
        ...
        }
        ...
}

Thank you,
Kyungmin Park
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/