Re: [PATCH] PCI: conditional resource-reallocation through kernelparameter pci=realloc

[Stephen Rothwell]

Hi Jesse,

On Wed, 6 Jul 2011 09:07:33 -0700 Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> wrote:
>
> On Wed, 6 Jul 2011 02:06:38 -0700
> Ram Pai <linuxram@xxxxxxxxxx> wrote:
> 
> > On Thu, Jun 30, 2011 at 01:09:39AM -0700, Ram Pai wrote:
> > > Multiple attempts to dynamically reallocate pci resources have unfortunately
> > > lead to regressions. Though we continue to fix the regressions and fine tune the
> > > dynamic-reallocation behavior, we have not reached a acceptable state yet.
> > > 
> > > This patch provides a interim solution. It disables dynamic-reallocation; by
> > > default, with the ability to enable it through pci=realloc kernel command line
> > > parameter.
> > 
> > > 
> > > Signed-off-by: Ram Pai <linuxram@xxxxxxxxxx>
> > > ---
> > >  Documentation/kernel-parameters.txt |    2 ++
> > >  arch/x86/pci/common.c               |    4 ++++
> > >  drivers/pci/setup-bus.c             |    7 +++++++
> > >  include/linux/pci.h                 |    2 ++
> > >  4 files changed, 15 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
> > > index fd248a3..aa47be7 100644
> > > --- a/Documentation/kernel-parameters.txt
> > > +++ b/Documentation/kernel-parameters.txt
> > > @@ -2015,6 +2015,8 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
> > >  				the default.
> > >  				off: Turn ECRC off
> > >  				on: Turn ECRC on.
> > > +		realloc		reallocate PCI resources if allocations done by BIOS
> > > +				are erroneous.
> > > 
> > >  	pcie_aspm=	[PCIE] Forcibly enable or disable PCIe Active State Power
> > >  			Management.
> > 
> > Linus/Jesse,
> > 
> > 	Are we merging this patch in 3.0.0 ?
> 
> Yeah I think we probably should, since the alternative is still pretty
> large.
> 
> I'll queue it up with any other small patches that are needed at this
> point and send them over to Linus.

It breaks the powerpc build (see my other message).

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature