Re: [PATCH] remove unnecessary cache flush on v6 copypage

From: saeed bishara
Date: Thu Jul 07 2011 - 06:31:12 EST


On Thu, Jul 7, 2011 at 12:02 PM, Catalin Marinas
<catalin.marinas@xxxxxxx> wrote:
> On Thursday, July 7, 2011, heechul Yun <heechul@xxxxxxxxxxxx> wrote:
>> ARM: mm: remove unnecessary cache flush on v6 copypage
I think you better mention that this is regarding v6 nonaliasing mode.
>>
>> Signed-off-by: Heechul Yun <heechul@xxxxxxxxxxxx>
>
> I would clarify the commit log a bit stating that this flush is no
> longer necessary because of commit c0177800. We had a good reason for
> adding the flush initially.
I agree, but I would also mention that the flush was needed in order
to coherent between dcache and icache, and now this is being handled
by __sync_icache_dcache
saeed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/