Re: [PATCH 3/3] uml: os-Linux/main.c memory leak fix

[Richard Weinberger]

Am Donnerstag 07 Juli 2011, 18:37:48 schrieb Vitaliy Ivanov:
> >From 6db3c87f57e3e61d968da79f01fb21ba17fd5bc0 Mon Sep 17 00:00:00 2001
> 
> From: Vitaliy Ivanov <vitalivanov@xxxxxxxxx>
> Date: Thu, 7 Jul 2011 19:29:06 +0300
> Subject: [PATCH 3/3] uml: os-Linux/main.c memory leak fix
> 
> We should cleanup memory even though 'putenv' fails.
> 
> Signed-off-by: Vitaliy Ivanov <vitalivanov@xxxxxxxxx>
> ---
>  arch/um/os-Linux/main.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/um/os-Linux/main.c b/arch/um/os-Linux/main.c
> index fb2a97a..67fe012 100644
> --- a/arch/um/os-Linux/main.c
> +++ b/arch/um/os-Linux/main.c
> @@ -107,8 +107,8 @@ static void setup_env_path(void)
>  	snprintf(new_path, path_len, "PATH=%s" UML_LIB_PATH, old_path);
>  	if (putenv(new_path)) {
>  		perror("couldn't putenv to set a new PATH");
> -		free(new_path);
>  	}
> +	free(new_path);

Uhhh, this will kill the PATH variable.
putenv() does not copy the string...

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/