Re: [patch 00/17] CFS Bandwidth Control v7.1

[Peter Zijlstra]

On Thu, 2011-07-07 at 09:52 -0700, Andi Kleen wrote:
> Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> writes:
> >
> > +static void account_cfs_rq_runtime(struct cfs_rq *cfs_rq,
> > +               unsigned long delta_exec)
> > +{
> > +       if (!cfs_rq->runtime_enabled)
> > +               return;
> > +
> > +       cfs_rq->runtime_remaining -= delta_exec;
> > +       if (cfs_rq->runtime_remaining > 0)
> > +               return;
> > +
> > +       assign_cfs_rq_runtime(cfs_rq);
> > +}
> >
> > generate a call, only to then take the first branch out, marking that
> 
> You would need a *LOT* of calls to make up for 9%.
> 
> Maybe it's something else? Some profiling first before optimization
> is probably a good idea.

This is the 1.5% case where the feature is compiled in but not used.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/