Re: [PATCH 1/3] usbip: only dump valid port status

[Dan Carpenter]

On Mon, Jun 13, 2011 at 11:29:53PM +0200, Németh Márton wrote:
> From: Márton Németh <nm127@xxxxxxxxxxx>
> 
> The wIndex parameter of vhci_hub_control() is always zero when the
> request type is GetHubDescriptor, see drivers/usb/core/hub.c::get_hub_descriptor()
> and Universal Serial Bus Specification revision 2.0 (April 27, 2000) Section
> 11.24.2.5 "Get Hub Descriptor". This means the variable rhport will not contain
> any useful index. Only use valid rhport values.
> 

Is it possible for wValue to be zero if the request type is is
SetPortFeature or ClearPortFeature?  If so then we should probably
add some more checks to handle that.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/