Re: [09/35] ath9k: Fix suspend/resume when no interface is UP

From: Paul Gortmaker
Date: Sat Jul 09 2011 - 12:01:54 EST


On Fri, Jul 8, 2011 at 6:49 PM, Greg KH <gregkh@xxxxxxx> wrote:
> 2.6.32-longterm review patch.  If anyone has any objections, please let us know.
>
> ------------------
>
> From: Rajkumar Manoharan <rmanohar@xxxxxxxxxxxxxxxx>
>
> commit c31eb8e926835582cd186b33a7a864880a4c0c79 upstream.
>
> When no interface has been brought up, the chip's power
> state continued as AWAKE. So during resume, the chip never
> been powered up.
>
> Signed-off-by: Rajkumar Manoharan <rmanohar@xxxxxxxxxxxxxxxx>
> Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
>
> ---
>  drivers/net/wireless/ath/ath9k/pci.c |    6 ++++++
>  1 file changed, 6 insertions(+)
>
> --- a/drivers/net/wireless/ath/ath9k/pci.c
> +++ b/drivers/net/wireless/ath/ath9k/pci.c
> @@ -276,6 +276,12 @@ static int ath_pci_resume(struct pci_dev

This might warrant a double check.   The original was patching the
fullsleep into pci_suspend, not pci_resume, as is shown above here.

Paul.

>                            AR_GPIO_OUTPUT_MUX_AS_OUTPUT);
>        ath9k_hw_set_gpio(sc->sc_ah, sc->sc_ah->led_pin, 1);
>
> +       /* The device has to be moved to FULLSLEEP forcibly.
> +        * Otherwise the chip never moved to full sleep,
> +        * when no interface is up.
> +        */
> +       ath9k_hw_setpower(sc->sc_ah, ATH9K_PM_FULL_SLEEP);
> +
>        return 0;
>  }
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/