Re: [PATCH] Staging: comedi: Fixing style issues

From: Greg KH
Date: Sun Jul 10 2011 - 14:26:57 EST


On Sun, Jul 10, 2011 at 08:12:46PM +0200, markpearson_de@xxxxxxxx wrote:
> From: Mark Pearson <markpearson_de@xxxxxxxx>
>
> comedi_fops.c : Warning that externs should be avoided in .c files.
> A forward function decleration was declared extern
> although it was only used internally. Changed
> decleration to static.
> comedi.h : Fixed warning that storage class should be a the
> begining of declerations.
>
> Lindent ran on both files.
>
> Ignore previous patch - forgot to add signed off by.

Care to break this up into a set of "only do one thing per patch"
series? That way it's reviewable.

Also, running Lindent is usually a very bad idea on files that have been
around for a while now. It causes a lot of unneeded churn, please just
make the minor changes needed to be checkpatch.pl clean by hand.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/