Re: kmallocs with swapped parameters in fs/dlm/lock.c

[Jesper Juhl]

On Mon, 11 Jul 2011, Dr. David Alan Gilbert wrote:

> * Jesper Juhl (jj@xxxxxxxxxxxxx) wrote:
> > On Sun, 10 Jul 2011, Dr. David Alan Gilbert wrote:
> > 
> > > Hi David,
> > >   Sparse spotted a couple of places in fs/dlm/lock.c where the size/flags
> > > parameters to kmalloc got swapped:
> > > 
> > [...]
> > > Jesper:
> > >   I noticed in your patch:
> > > https://lkml.org/lkml/2011/7/2/90
> > > 
> > > where you had done a kmalloc->kzalloc transform you kept the swap.
> > > 
> > > This looks like new code in 3.0rc so I don't think you could quite
> > > call it a regression, but it should probably be fixed fairly quickly
> > > I guess.
> > > 
> > D'oh, I completely overlooked that.
> 
> No problem.
> 
> > Thank you for noticing and letting me know. I've just submitted an updated 
> > patch.
> 
> Great - it's probably worth you fixing the 2nd case in the same file
> in the same patch, rather than just the one that you were changing
> anyway?
> 
I guess so. I'll update my patch later this evening when I get home from 
work.

-- 
Jesper Juhl <jj@xxxxxxxxxxxxx>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/