Re: [PATCH 01/11] watchdog: WatchDog Timer Driver Core - Add basicframework

From: Alan Cox
Date: Tue Jul 12 2011 - 05:21:30 EST


> > + /* stop the watchdog */
> > + err = wdd->ops->stop(wdd);
> Does it really make sense to allow stop() to fail? Will this ever happen, and
> if yes do we gain anything by sending a additional ping?

It gives user space more time to react - or would do if the err was
propogated.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/