[PATCH] KVM: x86: Apply required parentheses in __check_direct_spte_mmio_pf

From: Jan Kiszka
Date: Tue Jul 12 2011 - 16:00:32 EST


From: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>

Comparison takes precedence over bitwise &, but the latter needs to be
evaluated first here.

Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
---

Avi, how's your 32-bit buildbot?

arch/x86/kvm/mmu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index d3d188e..9335e1b 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -448,7 +448,7 @@ static bool __check_direct_spte_mmio_pf(u64 spte)

/* It is valid if the spte is being zapped. */
if (sspte.spte_low == 0ull &&
- sspte.spte_high & high_mmio_mask == high_mmio_mask)
+ (sspte.spte_high & high_mmio_mask) == high_mmio_mask)
return true;

return false;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/