RE: [PATCH 4/5] fusb300_udc: Add missing breaks in switch/case

[Wendy Yuan-Hsin Chen(???)]

-----Original Message-----
From: Sebastian Andrzej Siewior [mailto:bigeasy@xxxxxxxxxxxxx] 
Sent: Thursday, July 14, 2011 6:36 PM
To: Wendy Yuan-Hsin Chen(???)
Cc: Felipe Balbi; Greg Kroah-Hartman; linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Joe Perches
Subject: Re: [PATCH 4/5] fusb300_udc: Add missing breaks in switch/case

* Wendy Yuan-Hsin Chen(??????) | 2011-07-14 16:36:39 [+0800]:

>>>diff --git a/drivers/usb/gadget/fusb300_udc.c
>>>b/drivers/usb/gadget/fusb300_udc.c
>>>index 06353e7..453bc0f 100644
>>>--- a/drivers/usb/gadget/fusb300_udc.c
>>>+++ b/drivers/usb/gadget/fusb300_udc.c
>>>@@ -688,10 +688,13 @@ static void fusb300_cmp_dbg_fifo(struct fusb300_ep *ep,
>>> 	switch (length % 4) {
>>> 	case 1:
>>> 		golden_value = *tmp;
>>>+		break;
>>> 	case 2:
>>> 		golden_value = *tmp | *(tmp + 1) << 8;
>>>+		break;
>>> 	case 3:
>>> 		golden_value = *tmp | *(tmp + 1) << 8 | *(tmp + 2) << 16;
>>>+		break;
>>> 	default:
>>> 		break;
>>> 
>
>>That is in an #if 0 block. Maybe we should remove the #if 0? Yuan-Hsin?
>
>It's ok to remove the #if 0. But the warning will occur while compling.

By removing the #if 0 block I meant to remove the unused functions
fusb300_cmp_dbg_fifo() and fusb300_dbg_fifo(). There should be no warning then.
Are you okey with this? Are those function required?

These funtions are used for debugging. I think it's ok to remove them. Thanks.

Yuan-Hsin

********************* Confidentiality Notice ************************
This electronic message and any attachments may contain
confidential and legally privileged information or
information which is otherwise protected from disclosure.
If you are not the intended recipient,please do not disclose
the contents, either in whole or in part, to anyone,and
immediately delete the message and any attachments from
your computer system and destroy all hard copies.
Thank you for your cooperation.
***********************************************************************

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/