Re: [PATCH] mm-slab: allocate kmem_cache with __GFP_REPEAT

From: Konstantin Khlebnikov
Date: Thu Jul 21 2011 - 03:18:31 EST


Matt Mackall wrote:
On Wed, 2011-07-20 at 20:41 +0300, Pekka Enberg wrote:
On Wed, 20 Jul 2011, Pekka Enberg wrote:
On Wed, 20 Jul 2011, Eric Dumazet wrote:
[PATCH v2] slab: shrinks sizeof(struct kmem_cache)

On Wed, 20 Jul 2011, Christoph Lameter wrote:
This will solve the issue for small nr_cpu_ids but those with 4k cpus will
still have the issue.

Acked-by: Christoph Lameter<cl@xxxxxxxxx>

Applied, thanks! Do we still want the __GFP_REPEAT patch from Konstantin
though?

On Wed, 20 Jul 2011, Christoph Lameter wrote:
Those with 4k cpus will be thankful I guess.

OTOH, I'm slightly worried that it might mask a real problem
with GFP_KERNEL not being aggressive enough. Mel?

I think that's already been demonstrated here, yes. It's just waiting
for another obscure workload to trigger it.


I Agree, __GFP_REPEAT doesn't fix the problem completely. So, some more detailed investigation required.
My case is not very honest, because my kernel has slightly different memory controller, and it has bugs for sure.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/