Re: [PATCH][TRIVIAL] net, netfilter: Remove redundant goto inebt_ulog_packet

From: Jiri Kosina
Date: Thu Jul 21 2011 - 08:02:53 EST


On Sun, 17 Jul 2011, Jesper Juhl wrote:

> In net/bridge/netfilter/ebt_ulog.c:ebt_ulog_packet() the 'goto unlock'
> before the 'alloc_failure' label is completely redundant. This patch
> removes it.
>
> Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
> ---
> net/bridge/netfilter/ebt_ulog.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/net/bridge/netfilter/ebt_ulog.c b/net/bridge/netfilter/ebt_ulog.c
> index 26377e9..bf2a333 100644
> --- a/net/bridge/netfilter/ebt_ulog.c
> +++ b/net/bridge/netfilter/ebt_ulog.c
> @@ -216,7 +216,6 @@ unlock:
> nlmsg_failure:
> pr_debug("error during NLMSG_PUT. This should "
> "not happen, please report to author.\n");
> - goto unlock;
> alloc_failure:
> goto unlock;
> }
> --
> 1.7.6
>
>
> PS. Please CC me on replies since I'm not subscribed to all the lists
> copied on this mail.

Doesn't seem to be present in linux-next as of today. I have picked it up.

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/