Re: [PATCH] x86, olpc: Fix dependency on POWER_SUPPLY

From: Ingo Molnar
Date: Sun Jul 24 2011 - 14:16:08 EST



* Daniel Drake <dsd@xxxxxxxxxx> wrote:

> As reported by Randy Dunlap, CONFIG_POWER_SUPPLY=m caused a compile error:
>
> arch/x86/built-in.o: In function `battery_status_changed':
> olpc-xo15-sci.c:(.text+0x3acdd): undefined reference to `power_supply_get_by_name'
> olpc-xo15-sci.c:(.text+0x3ad04): undefined reference to `power_supply_changed'
>
> The SCI drivers, as bool, require POWER_SUPPLY to be builtin. Use
> select to make that a hard requirement and avoid this build failure.
>
> Signed-off-by: Daniel Drake <dsd@xxxxxxxxxx>

Note that we generally try to add a Reported-by tag in such cases.

(i've added that, no need to resend.)

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/