Re: [PATCH] perf: Fix symbol resolution on old ppc64 ABI

From: Ingo Molnar
Date: Mon Jul 25 2011 - 02:26:39 EST



* Anton Blanchard <anton@xxxxxxxxx> wrote:

> The synthetic symbol creation code has an issue with the old ppc64
> ABI. We end up with duplicate symbols of different sizes that
> overlap.
>
> To fix this, walk all of the symbols and remove any duplicates that
> are the length of a function descriptor.

> I'd prefer not to add a ppc64 specific hack here, but I'm not sure
> how we can fix this in a simpler way.

Symbol space problems are common on other architectures as well.

We could use a heuristic: when symbols are overlapping then we could
throw away the one that is smaller. This would implicitly cover the
ppc64 case, right?

I'd also suggest we warn somewhere that a symbol has been thrown
away, if verbosity is turned off. (i.e. don't warn by default.)

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/