Re: [PATCH] sysctl: add support for poll()

[Lucas De Marchi]

On Mon, Jun 13, 2011 at 1:05 PM, Kay Sievers <kay.sievers@xxxxxxxx> wrote:
> On Thu, 2011-06-09 at 15:16 +0200, Kay Sievers wrote:
>> On Thu, Jun 9, 2011 at 00:17, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
>> > We already have several pollable procfs files, such as
>> > fs/proc/base.c:mounts_poll() and I think drivers/md has one.  I do
>> > think that any work in this area should end up with those custom
>> > make-procfs-pollable hacks being identified and removed.
>>
>> For these files we can probably move the event counter into the
>> seq_file structure, and get rid of the dance to kmalloc it and assign
>> it to seq_file->private. That might simplify the logic a bit.
>>
>> [Adding Neil, to get his opinion of moving 'event' so seq_file and get
>> rid of the malloc dance]
>
> I guess, we could do something like this, which looks quite a bit
> simpler by moving the poll event counter into the dynamically allocated
> seq_file structure itself, instead of having private structures
> allocated on top to just carry the counter (patch is just
> compile-tested).

Now that this cleanup made its way, could we look again to to the
pollable sysctl implementation?


thanks
Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/