Re: [GIT PULL] iscsi-target merge for v3.1-rc1

[Olivier Galibert]

On Tue, Jul 26, 2011 at 12:09:40AM -0700, Linus Torvalds wrote:
> And it just looks unnecessarily complicated. Just a simple
> 
> #define DIV_ROUND_UP_ULL(ll,d) \
>   ({ unsigned long long _tmp = (ll)+(d)-1; do_div(_tmp, d); _tmp; })
> 
> looks like it would work and be simpler. Avoid the conditional, do the
> same "add 'd-1' thing as the regular ROUND_UP().
> 
> Untested. And not much thinking involved.

Overflow risk?  Of course DIV_ROUND_UP has the same issue, and looks
slight easier to trigger, maybe.

  OG.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/